Make rule vue/no-unregistered-components ignore recursive components (#…

…1305) * Add tests * Modify rule to include `ignoreRecursive` argument * Modify docs * Address PR comments * empty commit * Refactor no-unregistered-components to always bypass recursive components * Update docs Co-authored-by: Joao Elias Arruda <joao.arruda@booking.com>
vuejs · Oct 18, 2020 · d626ec1 · d626ec1
1 parent ff78496
commit d626ec1
Show file tree

Hide file tree

Showing 2 changed files with 74 additions and 0 deletions.
diff --git a/lib/rules/no-unregistered-components.js b/lib/rules/no-unregistered-components.js
@@ -181,6 +181,15 @@ module.exports = {
       },
       utils.executeOnVue(context, (obj) => {
         registeredComponents.push(...utils.getRegisteredComponents(obj))
+
+        const nameProperty = utils.findProperty(obj, 'name')
+
+        if (nameProperty) {
+          registeredComponents.push({
+            node: nameProperty,
+            name: nameProperty.value.value
+          })
+        }
       })
     )
   }

diff --git a/tests/lib/rules/no-unregistered-components.js b/tests/lib/rules/no-unregistered-components.js
@@ -393,6 +393,71 @@ tester.run('no-unregistered-components', rule, {
         }
         </script>
       `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <CustomComponent />
+        </template>
+        <script>
+        export default {
+          name: 'CustomComponent'
+        }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <custom-component />
+        </template>
+        <script>
+        export default {
+          name: 'CustomComponent'
+        }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <component :is="'CustomComponent'" />
+        </template>
+        <script>
+        export default {
+          name: 'CustomComponent'
+        }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <component is="CustomComponent" />
+        </template>
+        <script>
+        export default {
+          name: 'CustomComponent'
+        }
+        </script>
+      `
+    },
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <div v-is="'CustomComponent'" />
+        </template>
+        <script>
+        export default {
+          name: 'CustomComponent'
+        }
+        </script>
+      `
     }
   ],
   invalid: [