Fix regression on no-unused-components rule (#1909)

vuejs · Jun 11, 2022 · cc35c58 · cc35c58
1 parent a8ab4fd
commit cc35c58
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/lib/rules/no-unused-components.js b/lib/rules/no-unused-components.js
@@ -120,13 +120,13 @@ module.exports = {
                       name === casing.camelCase(n))
                 )
               ) {
-                return
+                continue
               }
             } else {
               // In any other case the used component name must exactly match
               // the registered name
               if (usedComponents.has(name)) {
-                return
+                continue
               }
             }
 

diff --git a/tests/lib/rules/no-unused-components.js b/tests/lib/rules/no-unused-components.js
@@ -695,6 +695,36 @@ tester.run('no-unused-components', rule, {
           line: 13
         }
       ]
+    },
+
+    // Many components and one in middle is no present
+    {
+      filename: 'test.vue',
+      code: `
+        <template>
+          <div>
+            <Foo />
+            <fio.fio />
+            <baz />
+          </div>
+        </template>
+        <script>
+          export default {
+            components: {
+              Foo,
+              'fio.fio': FioFio,
+              Bar,
+              Baz
+            },
+          }
+        </script>
+      `,
+      errors: [
+        {
+          message: 'The "Bar" component has been registered but not used.',
+          line: 14
+        }
+      ]
     }
   ]
 })