Fix false positives for call expression in no-mutating-props rule. (#…

…1584)
vuejs · Jul 30, 2021 · 7664259 · 7664259
1 parent 1c99bcd
commit 7664259
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/utils/index.js b/lib/utils/index.js
@@ -1706,7 +1706,7 @@ module.exports = {
           const callName = getStaticPropertyName(mem)
           if (
             callName &&
-            /^push|pop|shift|unshift|reverse|splice|sort|copyWithin|fill$/u.exec(
+            /^(?:push|pop|shift|unshift|reverse|splice|sort|copyWithin|fill)$/u.exec(
               callName
             )
           ) {

diff --git a/tests/lib/rules/no-mutating-props.js b/tests/lib/rules/no-mutating-props.js
@@ -318,6 +318,19 @@ ruleTester.run('no-mutating-props', rule, {
         value.value++
         </script>
       `
+    },
+    {
+      // https://github.com/vuejs/eslint-plugin-vue/issues/1579
+      filename: 'test.vue',
+      code: `
+      <script>
+        export default {
+          props: ['prop'],
+          setup(props) {
+            props.prop.sortAscending()
+          }
+        }
+      </script>`
     }
   ],