Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caveats around mixing <script setup> and <script> #2149

Merged
merged 1 commit into from Jan 8, 2023

Conversation

skirtles-code
Copy link
Contributor

This PR is based on the conversation on vuejs/core#6242.

Using <script setup> alongside a separate <script> tag was intended as an escape hatch for some specific use cases, as described in the docs. But in practice it has been used in various other ways that were not really intended. However, the tone of the docs does not currently discourage that kind of usage.

This PR makes some of the caveats more explicit.

@netlify
Copy link

netlify bot commented Jan 5, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit a61af55
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/63b6711248b2bf00089e96ca
😎 Deploy Preview https://deploy-preview-2149--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@skirtles-code
Copy link
Contributor Author

@LinusBorg Would you mind checking that this change is an accurate description of the caveats around combining <script setup> and <setup>?

@NataliaTepluhina NataliaTepluhina merged commit 95aabcf into vuejs:main Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants