Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable devtool avoid chrome csp #2047

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kainstar
Copy link

@kainstar kainstar commented Apr 8, 2023

Description

When I use vue writing a chrome extension's popup page, the vue-devtool's client inject code can't work normally since it using eval function which is not allowed in chrome extension V3 manifest.

So I modify the shell-electron's client code webpack build config reference from shell-chrome package's build config, make it would not includes eval in dist code.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@@ -19,4 +19,7 @@ module.exports = createConfig({
publicPath: '/build/',
filename: '[name].js',
},
devtool: process.env.NODE_ENV !== 'production'
? 'inline-source-map'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
? 'inline-source-map'
? 'inline-source-map'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants