Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): Suspense get anchor properly in Transition #9309

Merged
merged 2 commits into from Dec 4, 2023
Merged

fix(runtime-core): Suspense get anchor properly in Transition #9309

merged 2 commits into from Dec 4, 2023

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 28, 2023 •
edited

close #8105

The root cause is that the anchor is unmounted before transition.afterLeave perform.

Note: The e2e test passed on my machine

@github-actions
Copy link

github-actions bot commented Sep 28, 2023 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.7 kB (-1 B) 33 kB (+4 B) 29.8 kB (+18 B)
vue.global.prod.js 133 kB (-1 B) 49.8 kB (+4 B) 44.6 kB

Usages

Name Size Gzip Brotli
createApp 48.2 kB 19 kB 17.4 kB
createSSRApp 51.5 kB 20.3 kB 18.5 kB
defineCustomElement 50.6 kB 19.7 kB 18 kB
overall 61.6 kB (-1 B) 23.8 kB (+6 B) 21.7 kB (+52 B)

This was referenced Oct 2, 2023
Closed
Merged
@antfu antfu added scope: transition scope: suspense 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Oct 3, 2023
pikax
pikax reviewed Oct 13, 2023
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyx990803 yyx990803 merged commit 65f3fe2 into vuejs:main Dec 4, 2023
11 checks passed
@pikax pikax mentioned this pull request Dec 4, 2023
Open
This was referenced Dec 4, 2023
Closed
Closed
@yyx990803 yyx990803 mentioned this pull request Dec 7, 2023
Closed
@edison1105 edison1105 mentioned this pull request Dec 7, 2023
Merged
This was referenced Jan 4, 2024
Closed
Closed
@sodatea sodatea mentioned this pull request Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax left review comments

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: suspense scope: transition
Projects
Issue / PR Management
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Transition> wrapped by <Suspense> breaks entirely if interrupted before it completes
4 participants
@edison1105 @pikax @antfu @yyx990803