fix(compiler-sfc): fix macro definition to preserve semicolons in some sceniarios #7810

yangxiuxiu1115 · 2023-03-01T12:06:45Z

…e scenarios

baiwusanyu-c

<script setup lang="ts">
console.log('Oups...')
const a = defineProps(['b'])
(window.testFunc) = () => 'props'
</script>

<script setup lang="ts">
console.log('Oups...')
const a = defineProps(['b']);
(window.testFunc) = () => 'props'
</script>

<script setup lang="ts">
console.log('Oups...')
defineProps(['b'])
;(window.testFunc) = () => 'props'
</script>

This case will still report an error

baiwusanyu-c · 2023-03-01T12:32:38Z

packages/compiler-sfc/__tests__/compileScript.spec.ts

@@ -1277,7 +1290,6 @@ const emit = defineEmits(['a', 'b'])
      expect(content).toMatch(`emits: ["foo", "bar"]`)
    })

-


Avoid adding or subtracting unnecessary spaces

baiwusanyu-c · 2023-03-01T12:33:13Z

packages/compiler-sfc/__tests__/compileScript.spec.ts

@@ -1136,7 +1149,7 @@ const emit = defineEmits(['a', 'b'])
      `)
      assertCode(content)
    })
-


Avoid adding or subtracting unnecessary spaces

yangxiuxiu1115 · 2023-03-01T12:34:42Z

I think the first are not necessary

…e sceniarios

…i/core into fix/compiler-sfc-semi

fix(compiler-sfc): fix macro definition to preserve semicolons in som…

421cf3a

…e scenarios

baiwusanyu-c reviewed Mar 1, 2023

View reviewed changes

RicardoErii added 3 commits March 1, 2023 20:58

fix(compiler-sfc): fix macro definition to preserve semicolons in som…

48865ae

…e sceniarios

fix: avoid adding or subtracting unnecessary spaces

f1080d2

Merge branch 'fix/compiler-sfc-semi' of https://github.com/RicardoEri…

6b5400b

…i/core into fix/compiler-sfc-semi

yangxiuxiu1115 closed this Mar 1, 2023

yangxiuxiu1115 mentioned this pull request Mar 1, 2023

Vue 3 SFC Compiler function call with semicolon bug. #7805

Closed

yangxiuxiu1115 deleted the fix/compiler-sfc-semi branch March 2, 2023 04:41

Provide feedback

		@@ -1277,7 +1290,6 @@ const emit = defineEmits(['a', 'b'])
		expect(content).toMatch(`emits: ["foo", "bar"]`)
		})