Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity-transform): semicolon after statements with nested destructure #7279

Closed

Conversation

skywalker512
Copy link

This commit adds a new semicolon after the reactivity-transform statements, but there may be problems with the nested destructure, here's a demo

image

@netlify
Copy link

netlify bot commented Dec 6, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 2226394
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/638edd33f39664000828355b

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem stills

<script setup lang="ts">
const { foo } = $({ foo: 123 }),
  a = 'b'
</script>

@sxzz
Copy link
Member

sxzz commented Dec 10, 2022

I just realized that it's not a necessity to add a semicolon after _toRef function of Reactivity Transform.

From the example of #6303, we should only add a semicolon in the first rectangle. It's actually not the scope of the reactivity transform, and it works now. But as the second rectangle, a semicolon should be added by $$ macro, instead of $ macro.
image

So let's track issue #6312 and discuss it I guess.

@sxzz
Copy link
Member

sxzz commented Jan 26, 2023

Unfortunately, Reactivity Transform has been dropped officially now, so I closed this issue/PR. If you want to keep using it, please consider the community version Vue Macros.

@sxzz sxzz closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants