Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler/runtime-dom): firefox do not support regexp flag s #7268

Closed
wants to merge 2 commits into from

Conversation

rudyxu1102
Copy link
Contributor

@rudyxu1102 rudyxu1102 commented Dec 3, 2022

Fix #7267

Related to #6808 #3917

Playground

@rudyxu1102 rudyxu1102 marked this pull request as draft December 3, 2022 07:03
@rudyxu1102 rudyxu1102 marked this pull request as ready for review December 3, 2022 07:50
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use \s\S instead of (.|\n) since some cases have already used it.

const forAliasRE = /([\s\S]*?)\s+(?:in|of)\s+([\s\S]*)/

@rudyxu1102
Copy link
Contributor Author

I prefer to use \s\S instead of (.|\n) since some cases have already used it.

const forAliasRE = /([\s\S]*?)\s+(?:in|of)\s+([\s\S]*)/

Thanks

@sodatea sodatea added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 16, 2023
@stondbringa
Copy link

Safari on iOS < 12 also impacted

@godxiaoji
Copy link
Contributor

May I ask when this PR will be merged? This compatibility issue may have a significant impact on the business.

@nickcartery
Copy link

I have the same issue, plz merge this PR!

@safonov-ruslan
Copy link

UP for merge! Please pay attention to this PR

@TNGD-YQ
Copy link

TNGD-YQ commented May 31, 2023

For whom may concern, the issue patched in v3.3.4
see 91f1c62

@stondbringa
Copy link

I confirm, issue is fixed in v3.3.4. Tested on Safari on iOS < 12 and firefox < 72

@edison1105
Copy link
Member

@stondbringa @TNGD-YQ
thanks.

@edison1105 edison1105 closed this May 31, 2023
@godxiaoji
Copy link
Contributor

Can this change be merged into version 3.2.x. The current version and accompanying tools (such as vite) no longer support Windows 7 (Node <13). Not very friendly to developers who cannot upgrade their systems (such as work computers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

invalid regular expression flag s
9 participants