Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): when Transition reports a warning about 'can only be used on a single element or component', it ignores the comments node. (fix #5675) #5708

Closed
wants to merge 2 commits into from

Conversation

baiwusanyu-c
Copy link
Member

when Transition reports a warning about 'can only be used on a single element or component', it ignores the comments node
fix: #5675

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 72db792
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6256a5751335640008db6cf2
😎 Deploy Preview https://deploy-preview-5708--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 72db792
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6256a575cb7ed60008bd0f9f
😎 Deploy Preview https://deploy-preview-5708--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 13, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 72db792
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6256a575058e7000086c1f6d
😎 Deploy Preview https://deploy-preview-5708--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yyx990803
Copy link
Member

Thanks for the PR, however it only gets rid of the warning and doesn't fix the transition behavior for #5675. See 62eba63

@yyx990803 yyx990803 closed this Apr 14, 2022
@baiwusanyu-c baiwusanyu-c deleted the fix/transition branch May 6, 2022 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments inside Transition are considered as a node
2 participants