Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: HMR on keepalive components caused error (fix #5073) #5165

Closed
wants to merge 4 commits into from

Conversation

Chenshyboy
Copy link

close #5073

@AlexDaniel
Copy link

Found this PR because yes, indeed, HMR is broken if I add keep-alive on the router-view.

That's the error:
image

I haven't tried applying the fix proposed in this PR, but 🤞🏼 that it's about the same issue :)

@peamed
Copy link

peamed commented Mar 6, 2022

Whether the problem has been solved and repaired, and whether the latest version has been solved. At present, I use "Vue": "^ 3.2.13"; The problem still exists

@AlexDaniel
Copy link

Can this get some attention, please? Working without HMR is extremely annoying.

@Math-chen
Copy link

@yyx990803 This problem has existed for a long time. there is a complete test case in hmr.spec.ts,at present, the latest version of Vue test cannot pass, although it is a small bug,but it is really annoying in development. please pay some attention to it, Thank you

@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for vue-next-template-explorer ready!

Name Link
🔨 Latest commit 7f3a64e
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/627615e2c7c5b300088cbe8f
😎 Deploy Preview https://deploy-preview-5165--vue-next-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for vuejs-coverage ready!

Name Link
🔨 Latest commit 7f3a64e
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/627615e2b3c7da00085f88e4
😎 Deploy Preview https://deploy-preview-5165--vuejs-coverage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 7, 2022

Deploy Preview for vue-sfc-playground ready!

Name Link
🔨 Latest commit 7f3a64e
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/627615e2d1fdbb000894a878
😎 Deploy Preview https://deploy-preview-5165--vue-sfc-playground.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mutolee
Copy link

mutolee commented Jul 3, 2022

@yyx990803 尝试了3.2.37版本,这个问题依然存在,希望能在下个版本中看到它被修复了,虽然刷新一下浏览器,它就没问题了,但每次热更它总出现在控制台里,很烦人, #4387 #5073 都是这个问题,谢谢了。

@feiyayshx
Copy link

同样的vue@3.2.37版本,同样的报错信息,使用vite构建,热更新无法使用

@KID-joker
Copy link

The first reload didn't trigger the onDeactivated.

@boundless-qi
Copy link

I find that this problem does not occur when using the option API. Only when using the setup API will the hot update fail!

@xuxing409
Copy link

xuxing409 commented Sep 27, 2022

I tried vue@3.2.37 version and still have this error

@pettyferlove
Copy link

实测3.2.45已经没有提示该错误

@zhangzhonghe
Copy link
Member

Thanks for your PR, but this issue has been fixed in v3.2.45, see #7049.

@teajaysee
Copy link

still getting this error on 3.2.45

@cn-2k
Copy link

cn-2k commented Apr 5, 2023

still getting this error on ^3.2.47

@INSIinc
Copy link

INSIinc commented May 28, 2023

still getting this error on ^3.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HMR on keepalive components caused error