fix(types): UnwrapRef should unwrap refs in collections when reading objects
#4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
requested changes
Nov 3, 2021
JensDll
force-pushed
the
fix_unwrap_ref_in_collection_types
branch
from
1d2b4bd
to
2754820
Compare
JensDll
commented
Nov 3, 2021
| @@ -66,9 +66,6 @@ export function isRef(r: any): r is Ref { | |||
| return Boolean(r && r.__v_isRef === true) | |||
| } | |||
|
|
|||
| export function ref<T extends object>( | |||
| value: T | |||
| ): [T] extends [Ref] ? T : Ref<UnwrapRef<T>> | |||
There was a problem hiding this comment.
I don't see the use case for this overload. Am I missing something here?
There was a problem hiding this comment.
Looks like this was added in #4734.
Should be save to remove as the added test still passes.
JensDll
force-pushed
the
fix_unwrap_ref_in_collection_types
branch
4 times, most recently
from
e13e797
to
a563b7c
Compare
JensDll
changed the title
UnwrapRef should unwrap refs in collectionsUnwrapRef should unwrap refs in collections when reading objects
JensDll
force-pushed
the
fix_unwrap_ref_in_collection_types
branch
from
a563b7c
to
eb4a784
Compare
JensDll
force-pushed
the
fix_unwrap_ref_in_collection_types
branch
from
03dc12a
to
c0cb8bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnwrapRefdoes not represent the ref unwrapping behavior correctly for refs in native collections (refs are unwrapped when reading from objects).Sandbox link to reproduction
The branch is based on #3820 because it is not merged yet.To make it simpler to follow, I removed the changes in #3820 and just included the ones for this feature.