Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-dom): style patching preserve v-show display property properly #4769

Closed
wants to merge 1 commit into from
Closed

fix(runtime-dom): style patching preserve v-show display property properly #4769

wants to merge 1 commit into from

Conversation

edison1105
Copy link
Member

fix #4768

@edison1105 edison1105 added the need test The PR has missing test cases. label Oct 9, 2021
@zhaozhongyu
Copy link

您的这个提交有bug, 没有考虑到如果用户使用的写法如果是:style="{ 'display': xxx }"的情况, 而且, 也没有考虑到如果用户不通过v-show的方式在style计算中将display设为none的情况.

@zhaozhongyu
Copy link

我修改了codepen实例, 您可以直接在示例上测试不同情况

@edison1105
Copy link
Member Author

@zhaozhongyu Okay, Your PR looks better. I will close this one.

@edison1105 edison1105 closed this Oct 9, 2021
@edison1105 edison1105 deleted the fix/4768 branch October 10, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
need test The PR has missing test cases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v-show conflicts with style display binding
2 participants
@edison1105 @zhaozhongyu