Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): declared prop keys should always exist in props argument #3726

Merged
merged 1 commit into from May 12, 2021
Merged

fix(types): declared prop keys should always exist in props argument #3726

merged 1 commit into from May 12, 2021

Conversation

Justineo
Copy link
Member

@Justineo Justineo commented May 6, 2021

A follow-up for vuejs/rfcs#293.

@Justineo Justineo requested a review from pikax May 6, 2021 12:45
@HcySunYang HcySunYang added 🐞 bug Something isn't working scope: types labels May 11, 2021
@yyx990803 yyx990803 merged commit 9b160b9 into vuejs:master May 12, 2021
@Justineo Justineo deleted the props-arg-types branch May 12, 2021 23:44
@johnsoncodehk
Copy link
Member

props key reference(#3656) is broken by LooseRequired. Is this necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

@HcySunYang HcySunYang HcySunYang approved these changes

Assignees
No one assigned
Labels
🐞 bug Something isn't working scope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Justineo @johnsoncodehk @pikax @HcySunYang @yyx990803