Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): handle error in async watchEffect #3129

Merged
merged 1 commit into from Mar 23, 2021
Merged

fix(runtime-core): handle error in async watchEffect #3129

merged 1 commit into from Mar 23, 2021

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 30, 2021 •
edited

close #3127

@edison1105 edison1105 changed the title fix(runtime-core): handle error in async watchEffect fix(runtime-core): handle error in async watch & watchEffect Jan 30, 2021
@edison1105 edison1105 changed the title fix(runtime-core): handle error in async watch & watchEffect fix(runtime-core): handle error in async watchEffect Jan 30, 2021
@LinusBorg LinusBorg added this to Planned, might need fresh review in Next Patch Feb 4, 2021
@posva
Copy link
Member

posva commented Mar 9, 2021

There is a similar open PR for Vue 2 at vuejs/vue#9484 that should also be merged if this gets aproved

@LinusBorg LinusBorg moved this from Planned, might need fresh review to Approved in Next Patch Mar 19, 2021
@LinusBorg LinusBorg added 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. and removed 🔍 review needed labels Mar 19, 2021
@LinusBorg LinusBorg merged commit eb1fae6 into vuejs:master Mar 23, 2021
Next Patch automation moved this from Approved to Done Mar 23, 2021
@LinusBorg LinusBorg moved this from Done to Final (Reviewed by Evan) in Next Patch Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

@HcySunYang HcySunYang HcySunYang approved these changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The error thrown in async effect is not passed to the app.config.errorHandler
5 participants
@edison1105 @posva @antfu @HcySunYang @LinusBorg