feat(server-renderer): catch errors from all promises in unrollBuffer() #10639
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In server-renderer, a
SSRBuffer
may contain multiple promises.Currently
unrollBuffer()
throws immediately when the first promise is rejected / throws an errorIn this case, the remaining promises will be ignored.
If any of these ignored promises also reject / throw an error, nodejs will throw an
unhandledRejection
event and shutdown / crash by default.This pr tries to improve the situation by collecting the errors from all promises and, if more than one error has been thrown, throw a
MultipleErrors
error, which contains these errors.The same issue has been discussed here: #7660, but instead of ignoring all errors, this pr keeps the existing behaviour for 0 or 1 errors, and returns all errors if multiple happened.