Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: verify commit msg. #10456

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: verify commit msg. #10456

wants to merge 2 commits into from

Conversation

lsc9
Copy link

@lsc9 lsc9 commented Mar 5, 2024

When I try to make vue core a submodule of my project:

git submodule add https://github.com/vuejs/core.git

do something and git commit:

git commit -am "docs: add comments."

it will throw error:

➜  core git:(heads/v3.4.21) ✗ git commit -am "docs: add comments."
✔ Preparing lint-staged...
✔ Running tasks for staged files...
✔ Applying modifications from tasks...
✔ Cleaning up temporary files...

> @3.4.21 check /Volumes/work_data/Web_data/Web_project/code/Vue3/source/core
> tsc --incremental --noEmit

node:fs:453
    return binding.readFileUtf8(path, stringToFlags(options.flag));
                   ^

Error: ENOTDIR: not a directory, open '/Volumes/work_data/Web_data/Web_project/code/Vue3/source/core/.git/COMMIT_EDITMSG'
    at readFileSync (node:fs:453:20)
    at file:///Volumes/work_data/Web_data/Web_project/code/Vue3/source/core/scripts/verify-commit.js:7:13
    at ModuleJob.run (node:internal/modules/esm/module_job:218:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:329:24)
    at async loadESM (node:internal/process/esm_loader:34:7)
    at async handleMainPromise (node:internal/modules/run_main:113:12) {
  errno: -20,
  code: 'ENOTDIR',
  syscall: 'open',
  path: '/Volumes/work_data/Web_data/Web_project/code/Vue3/source/core/.git/COMMIT_EDITMSG'
}

Copy link

github-actions bot commented Mar 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB 34.4 kB 31 kB
vue.global.prod.js 148 kB 53.7 kB 47.9 kB

Usages

Name Size Gzip Brotli
createApp 50.7 kB 19.8 kB 18.1 kB
createSSRApp 54.1 kB 21.1 kB 19.3 kB
defineCustomElement 53 kB 20.6 kB 18.7 kB
overall 64.4 kB 24.8 kB 22.5 kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant