Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition uses wrong leave-to class when HTML comments exists as template root #5500

Open
gmichaeljaison opened this issue Mar 2, 2022 · 2 comments · May be fixed by #5557
Open

Transition uses wrong leave-to class when HTML comments exists as template root #5500

gmichaeljaison opened this issue Mar 2, 2022 · 2 comments · May be fixed by #5557
Labels
🐞 bug Something isn't working scope: transition

Comments

@gmichaeljaison
Copy link

Version

3.2.31

Reproduction link

stackblitz.com

Steps to reproduce

Refer the stackblitz link and reproduce the issue by clicking on "Page A" and "Page B" navigations.

What is expected?

Transition should work as expected and noted by the transition-name regardless of existence of comments, i.e.
Page A should slide left
Page B should slide right

What is actually happening?

Leave transition is not updated for Page component with comments.
Page A slides right on leave transition
@gmichaeljaison gmichaeljaison changed the title Transition behaves unexpectedly when HTML comments exists as template root Transition uses wrong leave-to transition when HTML comments exists as template root Mar 2, 2022
@gmichaeljaison gmichaeljaison changed the title Transition uses wrong leave-to transition when HTML comments exists as template root Transition uses wrong leave-to class when HTML comments exists as template root Mar 2, 2022
@ygj6 ygj6 added the 🐞 bug Something isn't working label Mar 2, 2022
@posva
Copy link
Member

posva commented Mar 2, 2022

Duplicate of #5266

@posva posva marked this as a duplicate of #5266 Mar 2, 2022
@posva posva closed this as completed Mar 2, 2022
@ygj6 ygj6 linked a pull request Apr 18, 2022 that will close this issue
Open
@ygj6
Copy link
Member

ygj6 commented Apr 18, 2022

@posva I have tested, PR #5268 can not solve this issue, so it's not a duplicate.

@ygj6 ygj6 reopened this Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug Something isn't working scope: transition
Projects
None yet
Milestone
No milestone
4 participants
@posva @sodatea @gmichaeljaison @ygj6