Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Transition> leave effect is broken because of an <!-- HTML comment --> #5266

Closed
scambier opened this issue Jan 15, 2022 · 0 comments · Fixed by #5268
Closed

<Transition> leave effect is broken because of an <!-- HTML comment --> #5266

scambier opened this issue Jan 15, 2022 · 0 comments · Fixed by #5268
Labels
🐞 bug Something isn't working scope: transition

Comments

@scambier
Copy link

scambier commented Jan 15, 2022 •
edited

Version

3.2.26

Reproduction link

sfc.vuejs.org/

Steps to reproduce

Open the repro link, and see the "hello" text appearing and disappearing once per second, but the v-leave-to effect is ignored.

The Comp.vue has a <!-- Broken! --> comment, that can be removed to fix the issues.

What is expected?

The text should fade in and out smoothly, even with a root HTML comment

What is actually happening?

The fade out effect is cancelled, and the text disappears abruptly

I guess that the compiler considers the comment as another "standard" element, which the <Transition> doesn't support.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐞 bug Something isn't working scope: transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Transition): dev root fragment should have transition edison1105/vuejs-core
2 participants
@scambier @edison1105