fix: do not handle false + move into lower branch

vuejs · Apr 13, 2022 · 59a6eb5 · 59a6eb5
1 parent 4f2deb3
commit 59a6eb5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/runtime-dom/__tests__/patchStyle.spec.ts b/packages/runtime-dom/__tests__/patchStyle.spec.ts
@@ -39,15 +39,15 @@ describe(`runtime-dom: style patching`, () => {
     const el = document.createElement('div')
     patchProp(el, 'style', null, {
       color: undefined,
-      '--color': false,
       borderRadius: null
     })
     expect(el.style.cssText.replace(/\s/g, '')).toBe('')
+
     patchProp(
       el,
       'style',
       { color: 'red' },
-      { color: undefined, '--color': false, borderRadius: false }
+      { color: null, borderRadius: undefined }
     )
     expect(el.style.cssText.replace(/\s/g, '')).toBe('')
   })

diff --git a/packages/runtime-dom/src/modules/style.ts b/packages/runtime-dom/src/modules/style.ts
@@ -42,10 +42,10 @@ function setStyle(
   name: string,
   val: string | string[]
 ) {
-  val = val == null || (val as any) === false ? '' : val
   if (isArray(val)) {
     val.forEach(v => setStyle(style, name, v))
   } else {
+    if (val == null) val = ''
     if (name.startsWith('--')) {
       // custom property definition
       style.setProperty(name, val)