Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): should unwrap tuple correctly #706

Closed
wants to merge 1 commit into from
Closed

fix(types): should unwrap tuple correctly #706

wants to merge 1 commit into from

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented May 26, 2021 •
edited

fix #707.

@antfu
Copy link
Member

antfu commented May 27, 2021

Maybe it's better to be fixed in vue-next first https://github.com/vuejs/vue-next/blob/90aa8358129f25826bfc4c234325c1442aef8d55/packages/reactivity/src/ref.ts#L222-L222

@hyf0
Copy link
Contributor Author

hyf0 commented May 27, 2021

@antfu Yes, I sent a PR to fix it vuejs/core#3820 .

@hyf0 hyf0 force-pushed the should_unwrap_tuple_correctly branch from ffabf44 to c5f0ecf Compare May 27, 2021 10:21
@antfu antfu added the on hold label Jul 2, 2021
@github-actions
Copy link

Stale pull request message

@github-actions github-actions bot closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no-pr-activity on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

should unwrap tuple correctly
2 participants
@hyf0 @antfu