Skip to content

Commit

Permalink
chore: typo (#981)
Browse files Browse the repository at this point in the history
  • Loading branch information
dev-itsheng committed Apr 4, 2023
1 parent 0db7433 commit c2d60b7
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Expand Up @@ -30,7 +30,7 @@ jobs:
env:
CI: true

- name: Typing Declartion Tests
- name: Typing Declaration Tests
run: pnpm run test:dts
env:
CI: true
Expand Down
8 changes: 4 additions & 4 deletions README.md
Expand Up @@ -334,7 +334,7 @@ export default {

`reactive` uses `Vue.observable` underneath which will ***mutate*** the original object.

> :bulb: In Vue 3, it will return an new proxy object.
> :bulb: In Vue 3, it will return a new proxy object.
</details>

Expand Down Expand Up @@ -391,7 +391,7 @@ watch(() => {
⚠️ <code>createApp()</code> is global
</summary>

In Vue 3, `createApp()` is introduced to provide context(plugin, components, etc.) isolation between app instances. Due the the design of Vue 2, in this plugin, we provide `createApp()` as a forward compatible API which is just an alias of the global.
In Vue 3, `createApp()` is introduced to provide context(plugin, components, etc.) isolation between app instances. Due the design of Vue 2, in this plugin, we provide `createApp()` as a forward compatible API which is just an alias of the global.

```ts
const app1 = createApp(RootComponent1)
Expand Down Expand Up @@ -443,7 +443,7 @@ export default {
⚠️ <code>shallowReadonly()</code> will create a new object and with the same root properties, new properties added will <b>not</b> be readonly or reactive.
</summary>

> :bulb: In Vue 3, it will return an new proxy object.
> :bulb: In Vue 3, it will return a new proxy object.
</details>

Expand Down Expand Up @@ -553,6 +553,6 @@ defineComponent({

### Performance Impact

Due the the limitation of Vue2's public API. `@vue/composition-api` inevitably introduces some performance overhead. Note that in most scenarios, this shouldn't be the source of performance issues.
Due the limitation of Vue2's public API. `@vue/composition-api` inevitably introduces some performance overhead. Note that in most scenarios, this shouldn't be the source of performance issues.

You can check the [benchmark results](https://antfu.github.io/vue-composition-api-benchmark-results/) for more details.
2 changes: 1 addition & 1 deletion src/apis/watch.ts
Expand Up @@ -383,7 +383,7 @@ function createWatcher(
if (isReactive(watcher.value) && watcher.value.__ob__?.dep && deep) {
watcher.value.__ob__.dep.addSub({
update() {
// this will force the source to be revaluated and the callback
// this will force the source to be reevaluated and the callback
// executed if needed
watcher.run()
},
Expand Down
6 changes: 3 additions & 3 deletions test/v3/reactivity/del.spec.ts
Expand Up @@ -45,8 +45,8 @@ describe('reactivity/del', () => {
it('should trigger reactivity when using del on array to delete index out of valid array length', () => {
const arr = ref<number[]>([])
const MAX_VALID_ARRAY_LENGTH = Math.pow(2, 32) - 1
const NON_VALIDD_INDEX = MAX_VALID_ARRAY_LENGTH + 1
set(arr.value, NON_VALIDD_INDEX, 0)
const NON_VALID_INDEX = MAX_VALID_ARRAY_LENGTH + 1
set(arr.value, NON_VALID_INDEX, 0)
const spy = vi.fn()
watchEffect(
() => {
Expand All @@ -55,7 +55,7 @@ describe('reactivity/del', () => {
{ flush: 'sync' }
)
expect(spy).toBeCalledTimes(1)
del(arr.value, NON_VALIDD_INDEX)
del(arr.value, NON_VALID_INDEX)
expect(spy).toBeCalledTimes(2)
})
})
2 changes: 1 addition & 1 deletion test/v3/reactivity/effectScope.spec.ts
Expand Up @@ -132,7 +132,7 @@ describe('reactivity/effect/scope', () => {
await nextTick()
expect(dummy).toBe(7)

// nested scope should not be stoped
// nested scope should not be stopped
expect(doubled).toBe(12)
})

Expand Down
2 changes: 1 addition & 1 deletion test/vue.ts
@@ -1,5 +1,5 @@
// `vue.common.js` is required for shallow mounts.
// Typescript can not infer it properly, this file is a workround to set the type
// Typescript can not infer it properly, this file is a workaround to set the type

// @ts-ignore
import _vue from 'vue/dist/vue.common'
Expand Down

0 comments on commit c2d60b7

Please sign in to comment.