Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new login flow #930

Merged
merged 7 commits into from Aug 12, 2020
Merged

Fix new login flow #930

merged 7 commits into from Aug 12, 2020

Conversation

tiagonapoli
Copy link
Contributor

@tiagonapoli tiagonapoli commented Aug 10, 2020

What is the purpose of this pull request?

There were two issues with the new login flow, this PR solves them:

  • For some reason the previous package used to get a free port wasn't working properly on some OSs - The package was then changed from get-port to detect-port.
  • In WSL2 the address 127.0.0.1:port wasn't reachable. This was solved by specifying the hostname on server.listen.

Even though changing the address solved the problem for WSL2, some older WSL2 versions will still have this issue, and the solution is update to Windows to the latest version (at least 19041.421). However a reliable way of detecting if the user is on WSL2 or WSL1 is not that easy and because of this as a quick fix I decided to warn all WSL users about possible login issues regarding outdated windows versions.

How should this be manually tested?

yarn global add vtex@2.107.1-beta.1

Check if vtex login works properly.

Types of changes

  • Refactor (non-breaking change that only makes the code better)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Chores checklist

  • Update CHANGELOG.md

@tiagonapoli tiagonapoli requested a review from a team as a code owner August 10, 2020 21:49
@tiagonapoli tiagonapoli force-pushed the fix/login branch 2 times, most recently from 2202c60 to a1d5da2 Compare August 10, 2020 21:53
@tiagonapoli tiagonapoli force-pushed the fix/login branch 2 times, most recently from 7bfaf3a to 67f9450 Compare August 11, 2020 21:10
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: tiagonapoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: tiagonapoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Co-authored-by: Larícia Mota <lmmc2@cin.ufpe.br>
@tiagonapoli tiagonapoli changed the base branch from master to next-release August 12, 2020 15:28
@tiagonapoli tiagonapoli merged commit f4cd57f into next-release Aug 12, 2020
@tiagonapoli tiagonapoli deleted the fix/login branch August 12, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants