New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new login flow #930
Merged
Merged
Fix new login flow #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagonapoli
force-pushed
the
fix/login
branch
2 times, most recently
from
August 10, 2020 21:53
2202c60
to
a1d5da2
Compare
tiagonapoli
commented
Aug 10, 2020
tiagonapoli
commented
Aug 10, 2020
tiagonapoli
commented
Aug 10, 2020
tiagonapoli
commented
Aug 10, 2020
tiagonapoli
force-pushed
the
fix/login
branch
2 times, most recently
from
August 11, 2020 21:10
7bfaf3a
to
67f9450
Compare
tiagonapoli
commented
Aug 11, 2020
This reverts commit 1649e2e.
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
Signed-off-by: tiagonapoli <napoli.tiago96@gmail.com>
Signed-off-by: tiagonapoli <napoli.tiago96@gmail.com> Signed-off-by: Tiago Martins Nápoli <napoli.tiago96@gmail.com>
lariciamota
reviewed
Aug 11, 2020
Co-authored-by: Larícia Mota <lmmc2@cin.ufpe.br>
lariciamota
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
There were two issues with the new login flow, this PR solves them:
get-port
todetect-port
.127.0.0.1:port
wasn't reachable. This was solved by specifying the hostname onserver.listen
.Even though changing the address solved the problem for WSL2, some older WSL2 versions will still have this issue, and the solution is update to Windows to the latest version (at least 19041.421). However a reliable way of detecting if the user is on WSL2 or WSL1 is not that easy and because of this as a quick fix I decided to warn all WSL users about possible login issues regarding outdated windows versions.
How should this be manually tested?
Check if
vtex login
works properly.Types of changes
Chores checklist
CHANGELOG.md