Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/date picker known issues #713

Merged
merged 7 commits into from Jul 11, 2019
Merged

Fix/date picker known issues #713

merged 7 commits into from Jul 11, 2019

Conversation

ericreis
Copy link
Contributor

@ericreis ericreis commented Jul 10, 2019

What is the purpose of this pull request?

Fix DatePicker known issues.

What problem is this solving?

There were two main problems in the DatePicker component:

  1. The time selection was not internationalized. Fixes DatePicker time selection does not respect locale internationalization #593
  2. Typing was disabled. Fixes: Wrong typing behavior in DatePicker component #471

This PR fixes them both. This was possible because of this PRs:

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@ericreis ericreis requested a review from cmdalbem July 10, 2019 21:55
@ericreis ericreis self-assigned this Jul 10, 2019
Copy link
Contributor

@ohmyguigs ohmyguigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, don't forget the CHANGELOG tho

@ericreis ericreis force-pushed the fix/date-picker-known-issues branch from 1b03dcf to 1785612 Compare July 11, 2019 16:57
@ericreis ericreis requested a review from a team July 11, 2019 16:57
@ericreis ericreis merged commit 625e0d5 into master Jul 11, 2019
@ericreis ericreis deleted the fix/date-picker-known-issues branch July 11, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants