chore(store-ui): Remove '@storybook/addon-storysource' #989
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 949cc03:
|
|
@victorhmp where's the storeui preview? 😄 |
|
@igorbrasileiro Oooh! I think it won't show up because the base branch here is not master 😅 But here's how the table looks now (running locally): |
The other stories are also working as they should, right? |
victorhmp
force-pushed
the
feature/table
branch
from
b72dec6
to
f1bce00
Compare
victorhmp
force-pushed
the
chore/remove-storybook-addon-storysource
branch
from
94e8d83
to
0b378f7
Compare
Yes! Nothing changed in the others :) |
victorhmp
force-pushed
the
chore/remove-storybook-addon-storysource
branch
from
0b378f7
to
949cc03
Compare
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 949cc03 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/616db9f090fb690008034e0f 😎 Browse the preview: https://deploy-preview-989--storeui.netlify.app/ |
What's the purpose of this pull request?
Remove the Storybook add-on
@storybook/addon-storysource. We are already using the@storybook/addon-docsadd-on, which is already capable of generating the same code snippets we need, and these two packages being used at the same time caused some sort of conflict, as described in this issue: storybookjs/storybook#13362.This issue came to light after @igorbrasileiro spotted a bug in the Table component stories: #987 (comment).
How to test it?
The bug mentioned above should be solved in the deploy preview below. And the source code for all other stories should be working the same way as before.
References
storybookjs/storybook#13362