Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reworking spks reporter #79

Merged
merged 3 commits into from May 13, 2024
Merged

reworking spks reporter #79

merged 3 commits into from May 13, 2024

Conversation

wejdross
Copy link
Member

@wejdross wejdross commented Apr 19, 2024

Small rework of SPKS reporter . Idea behind that change is to report

day before 00:00 ----------> day before 23:59:59 | day_of report

instead of

last_24h | day_of_report

Prometheus API is pretty flexible and it's possible to use achieve that with simple query and receive Vector

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@wejdross wejdross requested a review from Kidswiss April 19, 2024 13:22
@wejdross wejdross added the enhancement New feature or request label Apr 19, 2024
@wejdross wejdross requested a review from zugao April 22, 2024 09:44
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks, the rest looks good.

Did you already check with tobru if the format is now correct?

pkg/cmd/spks.go Show resolved Hide resolved
pkg/cmd/spks.go Outdated Show resolved Hide resolved
pkg/cmd/spks.go Outdated Show resolved Hide resolved
wejdross and others added 2 commits April 22, 2024 14:44
Co-authored-by: Kidswiss <kid.gamer@gmail.com>
Co-authored-by: Kidswiss <kid.gamer@gmail.com>
@wejdross
Copy link
Member Author

I had no time to test it with Tobru so far, looks good to me, but I'd rather block prod deployment until he can verify - I don't want to push garbage data to prod endpoint

@wejdross wejdross requested a review from Kidswiss May 13, 2024 09:51
@wejdross wejdross merged commit 6a9bb3e into master May 13, 2024
3 checks passed
@wejdross wejdross deleted the spks_rework branch May 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants