Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Commodore component #14

Merged
merged 4 commits into from Sep 28, 2022
Merged

Add Commodore component #14

merged 4 commits into from Sep 28, 2022

Conversation

ccremer
Copy link
Contributor

@ccremer ccremer commented Sep 27, 2022

Summary

  • Adds a commodore component in subdir component
  • Updates docs
  • Update GH actions

Note: The current implementation may be incomplete and not actually working, since the business logic has yet to be implemented in #12

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

@ccremer ccremer added the enhancement New feature or request label Sep 27, 2022
@ccremer ccremer marked this pull request as ready for review September 27, 2022 09:56
Copy link
Contributor

@Kidswiss Kidswiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The schedule is not applicable for Exoscale, rest LGTM.

We may need to adjust a few things once #12 has been merged.

According to Exoscale, their usage data is updated after 06:00
@ccremer ccremer merged commit d02b844 into master Sep 28, 2022
@ccremer ccremer deleted the component branch September 28, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants