Prune and upgrade npm package dependencies #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
Signed-off-by: Peter Bomber <peter.bomber@microsoft.com>
peterbom
force-pushed
the
feature/upgrade-packages
branch
from
aeeab9a
to
fd9f566
Compare
peterbom
commented
Apr 2, 2024
| @@ -17,7 +17,9 @@ | |||
| "noImplicitAny": true, | |||
| "strictFunctionTypes": true, | |||
| "strictNullChecks": true, | |||
| "noImplicitThis": true | |||
| "noImplicitThis": true, | |||
| "esModuleInterop": true, | |||
There was a problem hiding this comment.
Setting esModuleInterop to true is recommended and required for compatibility with later versions of the K8s client library.
peterbom
commented
Apr 2, 2024
| "noImplicitThis": true | ||
| "noImplicitThis": true, | ||
| "esModuleInterop": true, | ||
| "skipLibCheck": true |
There was a problem hiding this comment.
Without setting this, we end up with type errors in the K8s client, the glob types, and shelljs.
Tatsinnit
approved these changes
Apr 15, 2024
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates dependencies to the latest versions, prior to enabling Dependabot to do this for us.
Change summary:
@typespackages have been removed where packages publish their own typesglobandrequest)tsconfig.jsonto prevent TypeScript analysing thenode_modulesdirectory and enable the recommendedesModuleInteropsetting)This builds, runs and passes automated tests, but it's probably worth doing some further manual testing.