Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): support jinja-java #3503

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shitian9
Copy link

@shitian9 shitian9 commented May 10, 2024

support jinja-java

Fixes #IssueNumber

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️

@robertohuertasm robertohuertasm added this to the Next milestone Jun 1, 2024
@robertohuertasm
Copy link
Member

We need to rebase for the test to work. Unfortunately I can't push force to your branch @shitian9

@robertohuertasm robertohuertasm modified the milestones: Next, Backlog Jun 1, 2024
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to rebase master before being able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants