Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): support vitest-snapshot language #3490

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

remcohaszing
Copy link
Contributor

@remcohaszing remcohaszing commented Apr 25, 2024

The vitest-snapshot language is registered by
https://marketplace.visualstudio.com/items?itemName=vitest.explorer.

The jest-snapshot was added too. This is registered by https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest.

The file pattern of Vitest snapshots is the same as Jest snapshots. To support both, the extensions were removed from the jest_snapshot icon.

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

The vitest-snapshot language is registered by
https://marketplace.visualstudio.com/items?itemName=vitest.explorer.

The jest-snapshot was added too. This is registered by
https://marketplace.visualstudio.com/items?itemName=Orta.vscode-jest.

The file pattern of Vitest snapshots is the same as Jest snapshots. To
support both, the extensions were removed from the `jest_snapshot` icon.
@remcohaszing
Copy link
Contributor Author

Alternatively we could come up with a custom icon. I just have no idea what it would be, nor do I have the design skills to create one.

robertohuertasm
robertohuertasm previously approved these changes Jun 1, 2024
@robertohuertasm robertohuertasm merged commit 0717a25 into vscode-icons:master Jun 1, 2024
16 checks passed
@remcohaszing remcohaszing deleted the vitest-snapshot branch June 1, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants