feat: add cmrc icon support #3458
Open
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ar-mane is that extension supposed to be a filename? or are the files having that |
robertohuertasm
requested changes
Jun 1, 2024
| @@ -2584,6 +2584,11 @@ export const extensions: IFileCollection = { | |||
| extensions: ['juice'], | |||
| format: FileFormat.svg, | |||
| }, | |||
| { | |||
| icon: 'cmrc', | |||
| extensions: ['cmrc.json'], | |||
There was a problem hiding this comment.
This won't work as a file extension. VS Code only takes the latest extension. It doesn't work with composed extensions.
There was a problem hiding this comment.
i got inspired from some files already existed,
i want to decorate the whole cmrc.json file. any suggestion how to ?
There was a problem hiding this comment.
actualy .cmrc as file name is better than .cmrc.json
I updated the extension config
with new commit, it works as it suppose to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the cmrc logo (a component generator : for https://cm.armane.dev ).
Fixes #IssueNumber
Changes proposed: