Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(contributing): specify creating a branch for PRs #3456

Merged

Conversation

adufr
Copy link
Contributor

@adufr adufr commented Mar 1, 2024

Fixes #IssueNumber
None

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Context:
I saw that many PRs were rejected because people were pushing to their master branch (I did it too); so I'm trying to save them (and yourself) some time by specifying not to in the contributing guide.

Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for your contribution ❤️

@robertohuertasm robertohuertasm added this to the Next milestone Jun 1, 2024
@robertohuertasm robertohuertasm merged commit 64afaeb into vscode-icons:master Jun 1, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants