fix(travis): fix travis nodejs version

[robertohuertasm]

Publish hasn't worked, I'm not sure why, but a quick look at the travis file shows that wiki pages were still using the former version of node.

[codeclimate]

Code Climate has analyzed commit 4c1c493 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (100% is the threshold).

This pull request will bring the total coverage in the repository to 100.0% (0.0% change).

View more on Code Climate.

[robertohuertasm]

It didn't worked. This seems something related to travis changing the expected behavior. I've seen build 4900 and it worked. Now, we're receiving an error warning in Travis:

I'm looking into this.

[robertohuertasm]

Fixed for the moment... It seems that Travis automatically set to true the new beta validation tool for our repo and that broke everything. At some point we may have to review our matrix to make it work with the new way of configuring travis or... move to github actions 😉

[KingDarBoja]

I do prefer the GitHub action path as it seems better to have everything at the same platform.

[robertohuertasm]

This is an example of how to fix this issue with the new travis semantics.

[JimiC]

wiki page generation should not interfere with publishing. I highly doubt that was the issue.

[JimiC]

GitHub action is far from ready. Did some testing, even tried to contribute to setup-node to no avail.

[robertohuertasm]

wiki page generation should not interfere with publishing. I highly doubt that was the issue.

You don't have to doubt, just read this comment and this one.

I just changed the version of node blindly hoping that it was that (although I was also doubting about its efficacy). I was in a rush (family issues) and wanted to fix this asap. Anyway, it wasn't going to hurt to bump the wiki generation node version.

Regarding GitHub Actions which was the problem you had? I've certainly not used it with node but I've been using them a lot lately and haven't found issues so far so it's just my curiosity asking.

[JimiC]

@robertohuertasm I've read the comments and still travis shouldn't mess up. After all, we didn't enable the config validation (even in settings it's disabled). I didn't change the node version for the wiki pages generation deliberately. Travis shouldn't care as the node version is explicitly declared. Never the less, it's travis we are talking about. 💩 are included.

Regarding GitHub action it's the setup-node that's is not in a satisfying state as I already said.

[robertohuertasm]

@JimiC I disabled the setting in travis myself. It was enabled (I guess Travis enabled it by default) and that was causing the misbehavior.

Regarding setup-node I just wanted to know what was making this tool not satisfying.

[JimiC]

Aahh that explains it.

[JimiC]

actions/setup-node#58 still pending

[KingDarBoja]

Pending for another PR, that's gonna take some time to get merged!