New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cjs and mjs support for babel #2334
feat: add cjs and mjs support for babel #2334
Conversation
This definitely needs to be reduced using |
@robertohuertasm knows something about it I suppose. |
I was looking at the docs and |
Maybe keep |
@JimiC @KingDarBoja I don't think we should keep |
@xiaoxiangmoe If we only lived in a perfect world... |
@KingDarBoja @JimiC @ManzDev I can't find
#2319 also introduced |
Ask @ManzDev. |
90e4a3d
to
fbfa728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@xiaoxiangmoe I've received a notification from GitHub of a message from you that I cannot find anymore asking for updates (probably you deleted it). Thanks for this PR and the rest of the team for their supervision. It's merged now! 🎉 |
Fixes #IssueNumber
Changes proposed:
see babel/babel#10599 and babel/babel#10903