Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support mjs/cjs config file extension for eslint #2328

Merged
merged 1 commit into from Feb 13, 2020
Merged

support mjs/cjs config file extension for eslint #2328

merged 1 commit into from Feb 13, 2020

Conversation

xiaoxiangmoe
Copy link
Contributor

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

see eslint/rfcs#43 and eslint/eslint#12321

@KingDarBoja
Copy link
Member

From the above PRs, specifically at configuring.md changes on eslint/eslint#12321:

  • JavaScript (ESM) - use .eslintrc.cjs when running ESLint in JavaScript packages that specify "type":"module" in their package.json. Note that ESLint does not support ESM configuration at this time.

So I don't see .mjs being included as well.

@KingDarBoja KingDarBoja added this to the Next milestone Jan 6, 2020
@xiaoxiangmoe
Copy link
Contributor Author

xiaoxiangmoe commented Jan 6, 2020 •
edited

@KingDarBoja .mjs will be included in the future version.

KingDarBoja
KingDarBoja approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I don't see any problem supporting .mjs in the meantime.

@robertohuertasm robertohuertasm merged commit 17f9cde into vscode-icons:master Feb 13, 2020
@evanplaice
Copy link

evanplaice commented Feb 17, 2020 •
edited

FYI, ESLint currently only supports CommonJS configs. .mjs would only be necessary if ESLint adds support for ESM as a configuration format.

@afflexux afflexux mentioned this pull request Feb 17, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
file icons
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xiaoxiangmoe @KingDarBoja @evanplaice @robertohuertasm