Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add Windows specific husky settings to fix hooks #544

Merged
merged 2 commits into from Dec 9, 2021

Conversation

LJKaski
Copy link
Collaborator

@LJKaski LJKaski commented Dec 7, 2021

This PR adds a workaround for husky related problems on windows. On push, husky exited with an error stating stdin is not a tty. This fix was implemented before, but was apparently lost when updating the dependencies.

The thread where this fix was found: typicode/husky#850

@LJKaski LJKaski added the bug Something isn't working label Dec 7, 2021
@LJKaski LJKaski self-assigned this Dec 7, 2021
@LJKaski LJKaski added this to In progress in suomifi-design-system via automation Dec 7, 2021
ketsappi
ketsappi previously approved these changes Dec 8, 2021
Copy link
Contributor

@ketsappi ketsappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • Tested to make changes and commit locally. No hiccups there after this change.
  • Tested to build and run locally.
  • EDIT: Tested pre-push on another branch for this and seems to work also.

@LJKaski LJKaski merged commit 57643e7 into develop Dec 9, 2021
suomifi-design-system automation moved this from In progress to Done Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants