🐛 Controlled Accordion の初期値に対してアコーディオンが開かない #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deatiger
requested review from
Ryu955,
NAKKA-K,
trailstem and
shungenie
as code owners
🦋 Changeset detectedLatest commit: 0e98cc9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NAKKA-K
approved these changes
Apr 25, 2024
deatiger
commented
Apr 25, 2024
| const handleChange = (event: React.SyntheticEvent, expanded: boolean) => { | ||
| setExpandedState(expanded); | ||
| onChange && onChange(event, expanded); | ||
| const setContentStyle = (expanded: boolean) => { |
There was a problem hiding this comment.
アコーディオン開閉の state 変更時に set する css 用の state をまとめて変更する関数にした。
Comment on lines
63
to
66
| useEffect(() => { | ||
| setExpandedState(expanded); | ||
| setContentStyle(expanded); | ||
| }, [expanded]); |
There was a problem hiding this comment.
Controlled Accordion（アコーディオンの利用元で state を管理している場合）の初期値が反映されないようになっていたので修正した
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1605 の修正時の考慮漏れ
Check List (If️ you added new component in this PR)
src/components/index.ts.storybook/documents/Information/Samples/Samples.stories.tsx