Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codeowner #1603

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Add codeowner #1603

merged 1 commit into from
Apr 23, 2024

Conversation

shungenie
Copy link
Contributor

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx
  • Localize added component

Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: 5cbe399

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 5cbe399
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/662635935231720008ae486e
😎 Deploy Preview https://deploy-preview-1603--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@Ryu955 Ryu955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

めっちゃnitsなんだけど、publicリポジトリだし、適切なPR名が良いと思われ。

@shungenie shungenie changed the title コードオーナーに僕を追加 Add codeowner Apr 22, 2024
@shungenie
Copy link
Contributor Author

そうでしたmm

@shungenie shungenie requested a review from Ryu955 April 23, 2024 01:06
Copy link

@Ryu955 Ryu955 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shungenie shungenie merged commit a97fa33 into master Apr 23, 2024
2 checks passed
@shungenie shungenie deleted the add-shun-codeowner branch April 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants