Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ DualListBox のネストしたアイテムもチェックボックスを非表示にできるようにする #1602

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

deatiger
Copy link
Collaborator

@deatiger deatiger commented Apr 22, 2024

Check List (If️ you added new component in this PR)

  • Export the component in src/components/index.ts
  • Add example to .storybook/documents/Information/Samples/Samples.stories.tsx
  • Localize added component

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: 849d7bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
ingred-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 849d7bd
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/662641fe6fcc440008417d92
😎 Deploy Preview https://deploy-preview-1602--ingred-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator Author

@deatiger deatiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

スクリーンショット 2024-04-22 18 26 23
スクリーンショット 2024-04-22 18 26 28

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ネストしたアイテムもチェックボックスを非表示にできるようにした。
stories に書いている実装方法は、キャンペーンのターゲティングで実際に利用予定で、結構複雑になっているものの、「利用者側でよしなにする」という DualListBox のカスタマイズに対する設計思想に基づき、デザインシステム側では頑張って対応はしない。

@deatiger deatiger requested a review from shungenie April 22, 2024 09:29
@@ -230,47 +240,119 @@ export const WithoutCheckbox: StoryObj<DualListBoxProps> = {
);
};

console.log(
Copy link
Contributor

@shungenie shungenie Apr 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

このログは大丈夫なやつなのですかね?👀

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失礼、削除しました mm
849d7bd

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shungenie
修正したので、再レビューお願いします 🙏

@deatiger
Copy link
Collaborator Author

@noronaoki
念のため、DualListBox でネストしたアイテム内でもチェックボックスを使わないパターンを対応したのでご確認ください mm

https://deploy-preview-1602--ingred-ui.netlify.app/?path=/docs/components-data-display-duallistbox--docs#without-checkbox

@noronaoki
Copy link
Contributor

@deatiger
おー確かに、良さそうです!!LGTM

Copy link
Contributor

@shungenie shungenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅れてすみませんmm
LGTMです!

@deatiger deatiger merged commit ba081c1 into master Apr 23, 2024
3 checks passed
@deatiger deatiger deleted the disable-nested-checkbox branch April 23, 2024 04:51
@FluctMember FluctMember mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants