-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ DualListBox のネストしたアイテムもチェックボックスを非表示にできるようにする #1602
Conversation
🦋 Changeset detectedLatest commit: 849d7bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for ingred-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ネストしたアイテムもチェックボックスを非表示にできるようにした。
stories に書いている実装方法は、キャンペーンのターゲティングで実際に利用予定で、結構複雑になっているものの、「利用者側でよしなにする」という DualListBox のカスタマイズに対する設計思想に基づき、デザインシステム側では頑張って対応はしない。
@@ -230,47 +240,119 @@ export const WithoutCheckbox: StoryObj<DualListBoxProps> = { | |||
); | |||
}; | |||
|
|||
console.log( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このログは大丈夫なやつなのですかね?👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
失礼、削除しました mm
849d7bd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shungenie
修正したので、再レビューお願いします 🙏
@noronaoki |
@deatiger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
遅れてすみませんmm
LGTMです!
Check List (If️ you added new component in this PR)
src/components/index.ts
.storybook/documents/Information/Samples/Samples.stories.tsx