Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colors object type safe using satisfies #1017

Closed
wants to merge 6 commits into from

Conversation

takurinton
Copy link
Contributor

😎

No merging yet, merging will be done after the official release of TypeScript 4.9.

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for ingred-ui failed.

Name Link
🔨 Latest commit 3d9e33a
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/6385279e88be4d00097976c1

@takurinton takurinton changed the title WIP: use satisfies for type safe Use satisfies for type safe Nov 16, 2022
@takurinton takurinton changed the title Use satisfies for type safe colors object type safe using satisfies Nov 16, 2022
@takurinton
Copy link
Contributor Author

takurinton commented Nov 16, 2022

TS 4.9 support される issue は立ってるのでこれを待つ。typescript-eslint/typescript-eslint#5688
(コピペミスって最初内部の TS のバージョン上げる PR に link してしまってた、申し訳ない...)

@takurinton
Copy link
Contributor Author

TypeScript 4.9 対応されたのでいよいよマージできそう
#1112
#1113

@takurinton
Copy link
Contributor Author

lint and formatter の部分は通るようになった。
あと storybook

@takurinton takurinton closed this Dec 5, 2022
@takurinton takurinton deleted the remove-palette-todo-comment branch June 15, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant