Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MS Teams to chatops #151

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

tmu-sprd
Copy link
Contributor

This PR adds the ability to send notifications to Microsoft Teams. Currently Slack and RocketChat are supported.

The notifications are sent via an AdaptiveCard. The messages are colored: green for successful, red for errors and orange, if there are warnings in the r10k output.
The PostMessage function is extended to add the output of r10k hidden underneath a "Details" button.

This is the first time, I did something in Go. If there is something to improve, I'm happy for suggestions.

@bastelfreak bastelfreak added the enhancement New feature or request label Apr 23, 2024
README.md Outdated Show resolved Hide resolved
Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions before this can be approved

lib/chatops/chatops.go Show resolved Hide resolved
lib/chatops/teams.go Show resolved Hide resolved
@dhollinger
Copy link
Member

@tmu-sprd anything else you're waiting on before we merge this?

@tmu-sprd
Copy link
Contributor Author

@dhollinger I'm currently preparing a unit test for the teams function. Should be done this week.

@tmu-sprd
Copy link
Contributor Author

@dhollinger Added unit test for teams. My changes are done and ready for review. Thanks a lot

@TheMeier TheMeier requested a review from dhollinger June 2, 2024 16:33
Copy link
Member

@dhollinger dhollinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great work on the new feature!

@dhollinger dhollinger merged commit 1ab9ea3 into voxpupuli:master Jun 5, 2024
3 checks passed
@tmu-sprd tmu-sprd deleted the chatops_teams branch June 5, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants