Skip to content

Commit

Permalink
Even newer rubocop 1.22.1 and ruby 2.5
Browse files Browse the repository at this point in the history
  • Loading branch information
traylenator authored and alexjfisher committed Oct 18, 2021
1 parent 16a6ca4 commit 1fc31fa
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 4 deletions.
42 changes: 41 additions & 1 deletion rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ AllCops:
# Ruby 2.4 is the oldest version we can use with the latest version of rubocop (1.11.0 as of 13/03/2021).
# Puppet agent 5 ships with ruby 2.4. Puppetserver 5 has JRuby 2.1.x which is only ruby 2.3 compatible, but this
# is unlikely to cause many issues. If/when it does, we can disable the relevant cop inline as appropriate.
TargetRubyVersion: 2.4
TargetRubyVersion: 2.5
Include:
- '**/*.rb'
Exclude:
Expand Down Expand Up @@ -606,3 +606,43 @@ Style/RedundantArgument: # (new in 1.4)
Enabled: true
Style/SwapValues: # (new in 1.1)
Enabled: true
Layout/LineEndStringConcatenationIndentation: # new in 1.18
Enabled: true
Lint/AmbiguousOperatorPrecedence: # new in 1.21
Enabled: true
Lint/AmbiguousRange: # new in 1.19
Enabled: true
Lint/EmptyInPattern: # new in 1.16
Enabled: true
Lint/IncompatibleIoSelectWithFiberScheduler: # new in 1.21
Enabled: true
Lint/RequireRelativeSelfPath: # new in 1.22
Enabled: true
Security/IoMethods: # new in 1.22
Enabled: true
Style/InPatternThen: # new in 1.16
Enabled: true
Style/MultilineInPatternThen: # new in 1.16
Enabled: true
Style/NumberedParameters: # new in 1.22
Enabled: true
Style/NumberedParametersLimit: # new in 1.22
Enabled: true
Style/QuotedSymbols: # new in 1.16
Enabled: true
Style/RedundantSelfAssignmentBranch: # new in 1.19
Enabled: true
Style/SelectByRegexp: # new in 1.22
Enabled: true
Style/StringChars: # new in 1.12
Enabled: true
RSpec/ExcessiveDocstringSpacing: # new in 2.5
Enabled: true
RSpec/IdenticalEqualityAssertion: # new in 2.4
Enabled: true
RSpec/SubjectDeclaration: # new in 2.5
Enabled: true
RSpec/Rails/AvoidSetupHook: # new in 2.4
Enabled: true


6 changes: 3 additions & 3 deletions voxpupuli-test.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ Gem::Specification.new do |s|
s.add_runtime_dependency 'rspec-puppet-utils', '>= 1.9.5'

# Rubocop
s.add_runtime_dependency 'rubocop', '~> 1.11.0'
s.add_runtime_dependency 'rubocop-rspec', '~> 2.2.0'
s.add_runtime_dependency 'rubocop-rake', '~> 0.5.1'
s.add_runtime_dependency 'rubocop', '~> 1.22.1'
s.add_runtime_dependency 'rubocop-rspec', '~> 2.5.0'
s.add_runtime_dependency 'rubocop-rake', '~> 0.6.0'

# Linting
# meta gem to pull in all puppet-lint plugins + puppet-lint itself
Expand Down

0 comments on commit 1fc31fa

Please sign in to comment.