Add handling for additional r10k args in validate for control_branch #61
+32
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also handles default_branch and default_branch_override when dealing with :control_branch, based on how R10K::Module::Git does the lookup
ananace
force-pushed
the
validate-control_branch
branch
from
fd326fc to
1ed7a49
Compare
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 50.81% 50.81%
=======================================
Files 11 11
Lines 429 429
=======================================
Hits 218 218
Misses 211 211
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that I'd missed these keys when I was writing the code, so a late PR that adds an example and tests.
This PR then also handles
default_branchanddefault_branch_overridewhen dealing with :control_branch, based on howR10K::Module::Gitdoes the lookupThe resulting flow for figuring out the correct branch will then be;
$CONTROL_BRANCH> current branch >:default_branch_override>$CONTROL_BRANCH_FALLBACK>:default_branch>'main'