Fixes #52 - validate task fails when repo does not exist #53
+625
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananace
requested changes
Jul 3, 2020
ananace
reviewed
Jul 3, 2020
|
I also added ability to run coverage reports.
|
logicminds
force-pushed
the
bad_url
branch
2 times, most recently
from
a0c0740 to
b8cef26
Compare
ananace
requested changes
Jul 3, 2020
* previously if a git url did not exist or the user
did not have permission the validate task would crash.
This fixes that by handling bad urls and displaying an overall
failure for the git url.
|
I took out the coverage stuff and will craft a new PR |
ananace
approved these changes
Jul 4, 2020
|
thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously if a git url did not exist or the user
did not have permission the validate task would crash.
This fixes that by handling bad urls and displaying an overall
failure for the git url.
I ended up refactoring, by creating a new class called git_repo. This allowed me to test everything that was just git related. This new class might allow others to integrate with additional tasks too.
I also added ruby 2.6 support to the matrix.