Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modulesync #39

Merged
merged 6 commits into from Nov 26, 2021
Merged

Modulesync #39

merged 6 commits into from Nov 26, 2021

Conversation

smortex
Copy link
Member

@smortex smortex commented Oct 18, 2021

@smortex smortex mentioned this pull request Oct 18, 2021
@smortex smortex marked this pull request as draft October 25, 2021 20:58
@smortex
Copy link
Member Author

smortex commented Nov 26, 2021

Just removed the DELETE ME commit, updated the modulesync commit and fixed the new issues.

This is now ready for review 🎉

Copy link
Member

@root-expert root-expert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are we gonna add support for OSes on different PR or you forgot it? 😄

@smortex
Copy link
Member Author

smortex commented Nov 26, 2021

LGTM, are we gonna add support for OSes on different PR or you forgot it? smile

Yes, the first thing I would like to have is a working CI because it helps a lot!

@bastelfreak I think we usualy do merge commits but it seems to be disabled ATM. Do you want to enable it?

@bastelfreak
Copy link
Member

ups, fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants