Various fixes. #574
Various fixes. #574
Conversation
moduleroot/.rubocop.yml.erb
Outdated
| @@ -1,6 +1,6 @@ | |||
| require: rubocop-rspec | |||
| AllCops: | |||
| TargetRubyVersion: 1.9 | |||
| TargetRubyVersion: 2.3 | |||
There was a problem hiding this comment.
In the past we had the question about whether we should stay compatible with older versions because they're also synced to older versions. Also unsure about JRuby compatibility levels. Anyone has something useful to say so we don't break anything?
There was a problem hiding this comment.
So the question is whether we need to stay syntax compatible with older rubies and I honestly don't know the answer. If we do, then we need to pin rubocop.
There was a problem hiding this comment.
@ekohl
I dropped the changes in .rubocop.yml.erb since they conflict with the rubocop version '~> 0.49.1' preferred by vox-pupuli .
There was a problem hiding this comment.
jruby in puppetserver 5 is only ruby 1.9 compatible IIRC.
|
Breaking up into separate PR's per @alexjfisher . |
LICENSEpuppet-openvmtoolstomanaged_modules.ymlmoduleroot/.github/CONTRIBUTING.md.erb.ymlfiles.