Import + update typings from DefinitelyTyped #155
Conversation
|
Shoot I misclicked and created the PR without finishing my comment. In case you're reading this in an email: be sure to read my edit. |
|
In case anyone wants to use these definitions before this is merged without the hassle of git dependencies in node: I have published my fork here (be sure to use my fork of |
|
I'm not opposed to adding type definitions 👍 Does these ones have a dependency upon expressjs/session#656 ? |
|
That's great to hear! They shouldn't since I just added some methods, but I haven't explicitly tested it either (nor am I able to right now). |
|
@HoldYourWaffle Did you have any success in the DefinitelyTyped and/or Express project? |
|
Not really unfortunately. |
|
Just to give a little status update, more than a year later the upstream issues still hasn't been resolved. I have just created a second-attempt PR over at DT, hoping to finally get this fixed as soon as possible. |
|
It has been more than a year, but I'm happy to announce that DefinitelyTyped/DefinitelyTyped#46576 was finally merged! I'll try to update these definitions as soon as possible. |
|
Cool @HoldYourWaffle, thanks for the effort! |
|
any updates on this? |
|
@obedm503 No, not from me, been holding back a bit to see how DefinitelyTyped/DefinitelyTyped#46576 has been working out, but should be something I should look into when I have some time |
express-sessionis getting new typings that are incompatible with the current ones on DefinitelyTyped.I updated the typings for this module to stay compatible with these new upstream typings.
Because DefinitelyTyped is a mess and it's generally preferable to include typings directly in the package, I'm creating the PR here. If you don't want to include type definitions directly in the package I'll be happy to move this PR over to DT.
These updates should be backwards-compatible with those on DefinitelyTyped because I only added some missing definitions for functions.