Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Optimize samples #3082

Closed
wants to merge 16 commits into from
Closed

[WIP] Optimize samples #3082

wants to merge 16 commits into from

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented May 18, 2023 •
edited

Changes

  • Removes fiftyone.server.decorators.FiftyOneResponse in favor of a single dumps call
  • Adds pagination_data kwarg to fiftyone.server.view.get_view for omitting unnecessary DictField
  • Optimizes fiftyone.core.json.stringify
  • Removes fiftyone.core.json.FiftyOneJSONEncoder
  • Moves serialization to async tasks

TODO

  • Move modal sample data to an indepedent network request
  • Regression pass

@benjaminpkane benjaminpkane changed the base branch from develop to release/v0.21.0 May 18, 2023 21:37
ehofesmann
ehofesmann reviewed May 19, 2023
View reviewed changes
fiftyone/core/utils.py
@@ -1792,6 +1795,27 @@ def to_slug(name):
return slug


_T = t.TypeVar("_T")
_P = t.ParamSpec("_P")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe ParamSpec has a Python3.10+ requirement? HypothesisWorks/hypothesis#3397

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok will remove

@benjaminpkane benjaminpkane marked this pull request as ready for review May 19, 2023 16:28
@benjaminpkane
Copy link
Contributor Author

Stale

@benjaminpkane benjaminpkane deleted the optimize-samples branch May 22, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehofesmann ehofesmann ehofesmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjaminpkane @ehofesmann @sashankaryal