Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update signal-hook-tokio for tokio v1.0 #87

Merged
merged 2 commits into from
Jan 24, 2021
Merged

Conversation

bdash
Copy link
Contributor

@bdash bdash commented Jan 20, 2021

This drops support for pre-1.0 versions of tokio, and removes the per-version features and modules.

Fixes #83.

Copy link
Owner

@vorner vorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I somehow haven't managed to get around to this yet, so thanks for picking it up.

There are few details that need ironing out, but mostly this is what needed doing. Can you have a look at them?

signal-hook-tokio/Cargo.toml Outdated Show resolved Hide resolved
signal-hook-tokio/src/lib.rs Outdated Show resolved Hide resolved
signal-hook-tokio/src/lib.rs Outdated Show resolved Hide resolved
signal-hook-tokio/src/lib.rs Show resolved Hide resolved
This drops support for pre-1.0 versions of tokio, and removes the per-version features and modules.
signal-hook-tokio/src/lib.rs Outdated Show resolved Hide resolved
signal-hook-tokio/src/lib.rs Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jan 22, 2021

Codecov Report

Merging #87 (b3ad9eb) into master (1f271a0) will decrease coverage by 1.78%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   63.05%   61.26%   -1.79%     
==========================================
  Files          26       27       +1     
  Lines        3762     3565     -197     
  Branches      145      181      +36     
==========================================
- Hits         2372     2184     -188     
+ Misses       1389     1380       -9     
  Partials        1        1              
Impacted Files Coverage Δ
signal-hook-tokio/src/lib.rs 92.59% <84.61%> (+2.59%) ⬆️
signal-hook-tokio/tests/tests.rs 100.00% <100.00%> (ø)
src/flag.rs 74.41% <0.00%> (-17.01%) ⬇️
signal-hook-registry/src/half_lock.rs 75.36% <0.00%> (-2.98%) ⬇️
src/lib.rs 47.39% <0.00%> (-2.82%) ⬇️
build.rs 85.93% <0.00%> (-1.95%) ⬇️
src/low_level/siginfo.rs 70.96% <0.00%> (-1.59%) ⬇️
src/low_level/mod.rs 50.00% <0.00%> (ø)
src/low_level/signal_details.rs 27.27% <0.00%> (ø)
examples/print.rs 0.00% <0.00%> (ø)

signal-hook-tokio/src/lib.rs Show resolved Hide resolved
signal-hook-tokio/src/lib.rs Outdated Show resolved Hide resolved
@vorner
Copy link
Owner

vorner commented Jan 24, 2021

Thank you :-). Looks good.

Do you want to follow up with that cleanup right away, or should I spin up a release?

@vorner vorner merged commit 0c68852 into vorner:master Jan 24, 2021
@bdash bdash deleted the tokio-1.0 branch January 24, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update signal-hook-tokio for tokio 1.0
3 participants