Skip to content

Commit

Permalink
Merge pull request #41 from vorner/perf-comment-in-pr
Browse files Browse the repository at this point in the history
Include the PR commit about performance
  • Loading branch information
vorner committed Nov 23, 2020
2 parents 7ec8b39 + 56ffa02 commit 6e689b3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ comment:
coverage:
status:
project:
# Don't fail on coverage, only show
target: 0
default:
informational: true
18 changes: 14 additions & 4 deletions .github/workflows/benchmarks.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
on:
- pull_request
pull_request:
push:
branches:
- master
# Run once a week to preserve the cache
# (even though it still feels the cache gets lost sometimes?)
schedule:
- cron: '0 0 * * 0'

name: benchmark pull requests

Expand All @@ -24,7 +31,7 @@ jobs:
uses: Swatinem/rust-cache@v1

- name: Restore previous benchmark data
uses: actions/cache@v1
uses: actions/cache@v2
with:
path: ./bench-cache
key: ${{ runner.os }}-benchmark
Expand All @@ -45,7 +52,10 @@ jobs:
output-file-path: benches.out
github-token: ${{ secrets.GITHUB_TOKEN }}
auto-push: false
alert-threshold: '125%'
alert-threshold: '150%'
comment-on-alert: true
fail-on-alert: false
comment-always: true
fail-on-alert: true
external-data-json-path: ./bench-cache/benchmark-data.json
# Because it doesn't put it into the PR, it puts it into the commit :-|
alert-comment-cc-users: '@vorner'

0 comments on commit 6e689b3

Please sign in to comment.